Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): delay WebView#loadUrl call #683

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

In older webview versions, the WebViewClient::shouldInterceptRequest method is not invoked for the initial URL load. This is fixed if we delay the loadUrl() call by posting a message to the main thread. This was reported in Discord by a user testing on an emulator with API 28.

@lucasfernog lucasfernog requested a review from a team as a code owner September 4, 2022 18:54
@lucasfernog
Copy link
Member Author

lucasfernog commented Sep 4, 2022

We could also add an option for a custom error page validating the webview version like what Capacitor does: ionic-team/capacitor#5723 (though emitting an event is more like our way of doing things)

@lucasfernog lucasfernog merged commit b02cbd9 into dev Sep 4, 2022
@lucasfernog lucasfernog deleted the fix/android-url-load branch September 4, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants