feat: added text support to system tray - macos, closes #65 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
requested changes
Apr 19, 2022
Comment on lines
+108
to
+117
| /// Set new tray menu title. | ||
| /// | ||
| /// ## Platform-specific | ||
| /// | ||
| /// Only works on **macOS** | ||
| #[cfg(target_os = "macos")] | ||
| pub fn set_title(&mut self, title: &str) { | ||
| self.0.set_title(title) | ||
| } | ||
|
|
There was a problem hiding this comment.
This should be in SystemTrayExtMacOS trait and you should make a builder variant for SystemTrayBuilderExtMacOS.
You can find them in src/platform/macos.rs
|
this looks very promising, is there any way I can test this in my app? :) |
13 tasks
|
Since I'm waiting for this feature as well I created a new PR #554 The changes are the same as in this PR, I've just moved things to the existing traits as @amrbashir suggested and added support for the builder variant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Here's an example of the change, closes #65
Screen.Recording.2022-04-18.at.9.00.33.PM.mov
As this is my first contribution to tauri, please let me know of anything that needs to be done/changed for this to be accepted to be merged