fix test

taikoxyz · Jul 19, 2023 · 0be1db3 · 0be1db3
1 parent 5354874
commit 0be1db3
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 20 deletions.
diff --git a/packages/bridge-ui-v2/src/components/ChainSelector/ChainSelector.svelte b/packages/bridge-ui-v2/src/components/ChainSelector/ChainSelector.svelte
@@ -59,7 +59,7 @@
       } catch (err) {
         console.error(err);
 
-        if (error instanceof UserRejectedRequestError) {
+        if (err instanceof UserRejectedRequestError) {
           warningToast($t('messages.network.rejected'));
         }
       } finally {

diff --git a/packages/bridge-ui-v2/src/libs/token/checkMintable.test.ts b/packages/bridge-ui-v2/src/libs/token/checkMintable.test.ts
@@ -49,19 +49,6 @@ describe('checkMintable', () => {
     vi.clearAllMocks();
   });
 
-  it('should throw when wallet is not connected', async () => {
-    vi.mocked(getWalletClient).mockResolvedValueOnce(null);
-
-    try {
-      await checkMintable(BLLToken, mainnetChain.id);
-      expect.fail('should have thrown');
-    } catch (error) {
-      const { cause } = error as Error;
-      expect(cause).toBe(MintableError.NOT_CONNECTED);
-      expect(getWalletClient).toHaveBeenCalled();
-    }
-  });
-
   it('should throw when user has already minted', async () => {
     vi.mocked(mockTokenContract.read.minters).mockResolvedValueOnce(true);
 
@@ -100,7 +87,7 @@ describe('checkMintable', () => {
     } catch (error) {
       const { cause } = error as Error;
       expect(cause).toBe(MintableError.INSUFFICIENT_BALANCE);
-      expect(getPublicClient).toHaveBeenCalledWith({ chainId: mainnetChain.id });
+      expect(getPublicClient).toHaveBeenCalled();
       expect(mockTokenContract.estimateGas.mint).toHaveBeenCalledWith([mockWalletClient.account.address]);
       expect(mockPublicClient.getBalance).toHaveBeenCalledWith({ address: mockWalletClient.account.address });
     }

diff --git a/packages/bridge-ui-v2/src/libs/token/checkMintable.ts b/packages/bridge-ui-v2/src/libs/token/checkMintable.ts
@@ -6,9 +6,8 @@ import { getConnectedWallet } from '$libs/util/getWallet';
 import { MintableError, type Token } from './types';
 
 // Throws an error if:
-// 1. Wallet is not connected
-// 2. User has already minted this token
-// 3. User has insufficient balance to mint this token
+// 1. User has already minted this token
+// 2. User has insufficient balance to mint this token
 export async function checkMintable(token: Token, chainId: number) {
   const walletClient = await getConnectedWallet();
 

diff --git a/packages/bridge-ui-v2/src/libs/token/mint.test.ts b/packages/bridge-ui-v2/src/libs/token/mint.test.ts
@@ -28,7 +28,7 @@ describe('mint', () => {
     vi.mocked(getContract).mockReturnValue(mockTokenContract);
     vi.mocked(mockTokenContract.write.mint).mockResolvedValue('0x123456');
 
-    await expect(mint(BLLToken, mockWalletClient)).resolves.toEqual('0x123456');
+    await expect(mint(BLLToken)).resolves.toEqual('0x123456');
     expect(mockTokenContract.write.mint).toHaveBeenCalledWith([mockWalletClient.account.address]);
   });
 });
diff --git a/packages/bridge-ui-v2/src/libs/token/types.ts b/packages/bridge-ui-v2/src/libs/token/types.ts
@@ -14,7 +14,6 @@ export type TokenEnv = {
 };
 
 export enum MintableError {
-  NOT_CONNECTED = 'NOT_CONNECTED',
   TOKEN_MINTED = 'TOKEN_MINTED',
   INSUFFICIENT_BALANCE = 'INSUFFICIENT_BALANCE',
 }