Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (script): use docker internal port #45

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

BlankerL
Copy link
Contributor

@BlankerL BlankerL commented Apr 5, 2023

The original script was using public ports instead of internal docker ports. However, the l2_execution_engine relies on the internal docker IP of simple-taiko-node-l2_execution_engine, so it should be using internal docker ports as well.

Originally, if you change the default ports PORT_L2_EXECTION_ENGINE_HTTP and PORT_L2_EXECTION_ENGINE_WS in .env file, the prover relayer could not connect to the execution engine as it connects to the ports in .env file. However, it should connect to 8545 and 8546 to work properly.

@davidtaikocha davidtaikocha merged commit 1ef326a into taikoxyz:main Apr 5, 2023
@davidtaikocha
Copy link
Member

Merged, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants