Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle unix signals #224

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

Nakochi-crypto
Copy link
Contributor

Related: #60

Added the exec bash command to the taiko-client command so that the final running application becomes the container's PID 1.

See Best practices for Dockerfile instructions | Docker Docs.

Copy link
Contributor

@RogerLamTd RogerLamTd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RogerLamTd RogerLamTd merged commit 247ef63 into taikoxyz:main May 6, 2024
2 checks passed
Copy link

gitpoap-bot bot commented May 6, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Taiko Contributor:

GitPOAP: 2024 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@Nakochi-crypto Nakochi-crypto deleted the add-exec branch May 7, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants