Add Mezo testnet as a builtin network #3780
Conversation
Adds mezo network to the list of built in networks. The price for tBTC is retrieved as the price for the base network asset if coingecko fails.
Does not support reverse lookups yet
Pushes Ethereum and Mezo to the top of the list
hyphenized
force-pushed
the
mezo-network
branch
from
8fdacc1 to
6143867
Compare
|
(1) This doesn't seem to work if I've already added matsnet and then remove it. |
|
Just to check—can you drop a screenshot of what I should see in the network dropdown? I'll look at this some more tonight/tomorrow afternoon. |
|
When a custom network becomes a built-in network we want to work with the defined built-in network attributes over the custom ones. This also pushes stale data out of state
| // TBD: naming the normal reducer and async thunks | ||
| // Initialize redux from the db | ||
| // !!! Important: this action belongs to a regular reducer. | ||
| // NOT to be confused with the setNewCurrentAddress asyncThunk | ||
| this.store.dispatch(setSelectedAccount(dbAddressNetwork)) | ||
| const { address, network } = dbAddressNetwork |
There was a problem hiding this comment.
Can we kill the comment block above here? It's not doing anything for us.
| let supportedNetwork = this.chainService.supportedNetworks.find( | ||
| (net) => sameNetwork(network, net), | ||
| ) | ||
|
|
||
| if (!supportedNetwork) { | ||
| // eslint-disable-next-line prefer-destructuring | ||
| supportedNetwork = this.chainService.supportedNetworks[0] | ||
| } |
There was a problem hiding this comment.
When would this take effect?
There was a problem hiding this comment.
Hmmm think I was just being paranoid safe here 😬
| ) { | ||
| await this.networks.put(defaultNetwork) | ||
| } | ||
| await this.networks.put(defaultNetwork) |
There was a problem hiding this comment.
I'm torn about this change. Part of the reason we do this is we want people to be able to replace the default RPC with one that they prefer—this makes that completely impossible, I believe. We're also being hobbled a bit here by not allowing folks to (a) turn off built-in networks and (b) have the same network with a different RPC hooked up.
My thought overall is that if the user has already added the network, maybe we leave it alone—but if they remove it, our default entry should bubble up. Where I am in my local right now is that I had added matsnet, then I enabled the flag and opened the extension, then I removed matsnet, and currently I don't see it anywhere.
There was a problem hiding this comment.
Hmmm yeah I agree, I think we should give users the option to choose between a builtin network, and a custom one, with different RPCs even if they have the same chain ID.
Right now what this does is replaces the existing mezo "network" object, changing only it's name. Then here:
extension/background/services/chain/db.ts
Lines 355 to 365 in 76b590c
Default RPCs are merged with the already added custom RPC urls.
I'm having a hard time reproducing that last scenario, let's follow up on discord
|
Ok got this working. My local env was totally messed from previous stuff, unrelated to this PR. Seems like we probably need a token list that at least lists mUSD to start, yeah? Not a blocker though. |
There was a problem hiding this comment.
Given that we're behind a feature flag and in the interest of keeping things moving, going to go ahead and land this. Missing pieces:
- Token list so mUSD is verified up front & has a logo.
- Reverse name resolution via the latest Passport APIs.
- And then obv the stuff in Mezoification: Add base state and UI elements #3785.
Adds Mezo testnet as a built-in network, there's no support yet for reverse name resolution. The price for the network base asset is resolved as the price for tBTC.
Testing env
Latest build: extension-builds-3780 (as of Fri, 28 Feb 2025 13:20:05 GMT).