Merge pull request #273 from andrewminton/andrewminton-patch-1

Fatal Error if Role within a section fix
symphonycms · Dec 8, 2015 · 0969177 · 0969177
2 parents 0cd8da5 + 5f3987d
commit 0969177
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/extension.driver.php b/extension.driver.php
@@ -1165,7 +1165,10 @@ public function checkEventPermissions(array &$context){
 
 			$role = RoleManager::fetch($role_id);
 			$event_handle = strtolower(preg_replace('/^event/i', NULL, get_class($context['event'])));
-			$success = $role->canProcessEvent($event_handle, $action, $required_level) ? true : false;
+			$success = false;
+			if ($role) {
+  				$success = $role->canProcessEvent($event_handle, $action, $required_level) ? true : false;
+			}
 
 			$context['messages'][] = array(
 				'permission',

diff --git a/extension.meta.xml b/extension.meta.xml
@@ -17,6 +17,9 @@
     </author>
   </authors>
   <releases>
+    <release version="1.5.1" date="2015-12-08" min="2.4" max="2.6.x">
+      * [#272](https://github.com/symphonycms/members/issues/272) Role Permissions error
+    </release>
     <release version="1.5" date="2015-11-20" min="2.4" max="2.6.x">
       * [#267](https://github.com/symphonycms/members/issues/267) Symphony 2.6.x compatibilty
       * Ensure the Member Email class is always around