release stream add disconnect URLConnection, which may leading to the…

… exhaustion of resources
svga · Apr 24, 2019 · 2cea59d · 2cea59d
1 parent 1591ed8
commit 2cea59d
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/library/src/main/java/com/opensource/svgaplayer/SVGADynamicEntity.kt b/library/src/main/java/com/opensource/svgaplayer/SVGADynamicEntity.kt
@@ -39,18 +39,25 @@ class SVGADynamicEntity {
     fun setDynamicImage(url: String, forKey: String) {
         val handler = android.os.Handler()
         thread {
-            try {
-                (URL(url).openConnection() as? HttpURLConnection)?.let {
+            (URL(url).openConnection() as? HttpURLConnection)?.let {
+                try {
                     it.connectTimeout = 20 * 1000
                     it.requestMethod = "GET"
                     it.connect()
-                    BitmapFactory.decodeStream(it.inputStream)?.let {
-                        handler.post { setDynamicImage(it, forKey) }
+                    it.inputStream.use { stream ->
+                        BitmapFactory.decodeStream(stream)?.let {
+                            handler.post { setDynamicImage(it, forKey) }
+                        }
+                    }
+                } catch (e: Exception) {
+                    e.printStackTrace()
+                } finally {
+                    try {
+                        it.disconnect()
+                    } catch (disconnectException: Throwable) {
+                        // ignored here
                     }
-                    it.inputStream.close()
                 }
-            } catch (e: Exception) {
-                e.printStackTrace()
             }
         }
     }