Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Modernize samples #2664

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Kryptos-FR
Copy link
Member

@Kryptos-FR Kryptos-FR commented Mar 7, 2025

PR Details

Modernize the samples.

I did not enable the nullable feature since it isn't the case yet in the whole codebase. I also excluded the C# tutorials projects (beside using file scope namespaces) because we might to use a different style for them that is more beginner friendly.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR Kryptos-FR changed the title Feature/modernize samples refactor: Modernize samples Mar 7, 2025
@Kryptos-FR
Copy link
Member Author

We have a problem: the integrated code editor in the GameStudio is old and doesn't understand modern C#. It's thinking all modern lines of code are incorrect.

For example :
image

Therefore, we can't modernize the samples before we update (or get rid of) the code editor.

@IXLLEGACYIXL
Copy link
Collaborator

IXLLEGACYIXL commented Mar 7, 2025

the code editor uses roslyn of net6 the latest roslynpad would understand it

but updating it isnt as easy..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants