Update jest #503
Update jest #503
Conversation
|
This is failing due to It's a bug that's been fixed, but who knows when it'll be released - for now I'm going to leave this open and I'll update it when the next version of jest is released. |
|
This is now failing because Have opened an issue about getting it addressed. |
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| @@ -1020,8 +1020,10 @@ describe('volume', () => { | |||
| vol.writeFileSync('/lol.txt', '1'); | |||
| setTimeout(() => { | |||
| vol.watchFile('/lol.txt', { interval: 1 }, (curr, prev) => { | |||
| vol.unwatchFile('/lol.txt'); | |||
| done(); | |||
| process.nextTick(() => { | |||
There was a problem hiding this comment.
This may be ancient history at this point @G-Rath, so no worries if it's beyond recall; I was wondering if you managed to figure out what was going on with the watch/unwatch behaviour here, and whether there was anything reported upstream for it? Cheers!
Again did them all together, and also switched test env to
nodefor extra speed.Also chucked in a type for a private property on
Volume, as I was hanging around there tracking down the memory leak: it seems that callingunwatchFilefrom within thewatchFilecallback doesn't get applied completely until the next tick.This could technically be a bug, but I don't think it's an issue outside of situations like with jest since this is happening because jest considers anything on the next tick after
doneis called a leak.