Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Dselans/protos v0.1.16 updated #63

Merged
merged 10 commits into from
Jan 24, 2024
Merged

Conversation

dselans
Copy link
Contributor

@dselans dselans commented Jan 24, 2024

Several bits here:

  1. detective wasm was missing "return" for err case in validate_wasm_request -- was never hitting it - this made it difficult to write a test for on_error
  2. pipeline status wasn't getting filled out in an edge case - if last pipeline and last step AND step is said to abort current pipeline - resp would never get updated status
  3. Tested on_error
  4. wasm was returning FALSE on validate_wasm_request instead of ERROR
  5. died up tests

@dselans dselans merged commit fd058a5 into main Jan 24, 2024
1 check passed
@dselans dselans deleted the dselans/protos-v0.1.16-updated branch January 24, 2024 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant