Fix compiler warnings #1507

mhoyer-streamlabs · 2025-03-17T15:49:18Z

Description

Code changes fix compiler warnings, including both build warnings and Intellisense warnings. The majority of changes involve types and adding explicit casting. Other changes include initializing variables, checking for null pointers, and adding flags to ignore deprecation and security warnings. A handful of deprecated function calls were updated.

Motivation and Context

These changes were made so that legitimate warnings do not get lost in a sea of inconsequential warnings.

How Has This Been Tested?

Yarn tests completed successfully.

Types of changes

Tweak (non-breaking change to improve existing functionality)

Checklist:

[x ] The code has been tested.
[x ] All commit messages are properly formatted and commits squashed where appropriate.
[x ] I have included updates to all appropriate documentation.

Fixes for compiler warnings. The majority were mismatched types and some uninitialized variables. Added flags to suppress some deprecation/security warnings. Remove commented out line More compiler warning fixes Added some Intellisense warnings.

sandboxcoder · 2025-03-18T20:46:54Z

obs-studio-client/source/audio-track.cpp

@@ -46,7 +46,8 @@ osn::AudioTrack::AudioTrack(const Napi::CallbackInfo &info) : Napi::ObjectWrap<o
 {
 	Napi::Env env = info.Env();
 	Napi::HandleScope scope(env);
-	int length = info.Length();
+	size_t length = info.Length();
+	this->uid = 0;


Just curious why not initialize the variable in the constructor like so:

osn::AudioTrack::AudioTrack(const Napi::CallbackInfo &info) : Napi::ObjectWrap<osn::AudioTrack>(info), uid(0)

Old habits die hard...just fell back on how I used to do it.

sandboxcoder · 2025-03-18T20:55:21Z

obs-studio-client/source/audio-encoder.cpp

@@ -43,7 +43,8 @@ osn::AudioEncoder::AudioEncoder(const Napi::CallbackInfo &info) : Napi::ObjectWr
 {
 	Napi::Env env = info.Env();
 	Napi::HandleScope scope(env);
-	int length = info.Length();
+	size_t length = info.Length();
+	this->uid = 0;


I would initialize the variable in the constructor like so (unless there is some reason not to?):

osn::AudioEncoder::AudioEncoder(const Napi::CallbackInfo &info) : Napi::ObjectWrap<osn::AudioEncoder>(info), uid(0)

sandboxcoder · 2025-03-18T21:16:15Z

obs-studio-client/source/delay.cpp

@@ -44,7 +44,8 @@ osn::Delay::Delay(const Napi::CallbackInfo &info) : Napi::ObjectWrap<osn::Delay>
 {
 	Napi::Env env = info.Env();
 	Napi::HandleScope scope(env);
-	int length = info.Length();
+	size_t length = info.Length();
+	this->uid = 0;


I leave this up to you I would init this one in the constructor.

sandboxcoder · 2025-03-18T21:17:32Z

obs-studio-client/source/module.cpp

@@ -56,7 +56,8 @@ osn::Module::Module(const Napi::CallbackInfo &info) : Napi::ObjectWrap<osn::Modu
 {
 	Napi::Env env = info.Env();
 	Napi::HandleScope scope(env);
-	int length = info.Length();
+	size_t length = info.Length();
+	this->moduleId = 0;


I was thinking best to define in constructor?

sandboxcoder · 2025-03-18T21:18:44Z

obs-studio-client/source/nodeobs_display.cpp

 #include <node.h>
+#pragma warning(pop)
+//#include <node.h>


do we want to remove this or does the old deprecated code have value?

That actually wasn't intentional, just forgot to go back and delete.

sandboxcoder · 2025-03-18T21:19:22Z

obs-studio-client/source/reconnect.cpp

@@ -44,7 +44,8 @@ osn::Reconnect::Reconnect(const Napi::CallbackInfo &info) : Napi::ObjectWrap<osn
 {
 	Napi::Env env = info.Env();
 	Napi::HandleScope scope(env);
-	int length = info.Length();
+	size_t length = info.Length();
+	this->uid = 0;


define in constructor?

sandboxcoder · 2025-03-18T21:19:40Z

obs-studio-client/source/nodeobs_settings.cpp

 #include <node.h>
+#pragma warning(pop)
+//#include <node.h>


did we want to keep the dead code?

sandboxcoder · 2025-03-18T21:20:07Z

obs-studio-client/source/sceneitem.cpp

@@ -78,7 +78,8 @@ osn::SceneItem::SceneItem(const Napi::CallbackInfo &info) : Napi::ObjectWrap<osn
 {
 	Napi::Env env = info.Env();
 	Napi::HandleScope scope(env);
-	int length = info.Length();
+	size_t length = info.Length();
+	this->itemId = 0;


define in constructor?

sandboxcoder · 2025-03-18T21:22:56Z

obs-studio-client/source/video-encoder.cpp

@@ -52,7 +52,8 @@ osn::VideoEncoder::VideoEncoder(const Napi::CallbackInfo &info) : Napi::ObjectWr
 {
 	Napi::Env env = info.Env();
 	Napi::HandleScope scope(env);
-	int length = info.Length();
+	size_t length = info.Length();
+	this->uid = 0;


define in constructor?

sandboxcoder · 2025-03-18T21:28:52Z

obs-studio-client/source/callback-manager.cpp

@@ -135,21 +137,21 @@ void globalCallback::worker()
 				Napi::Array input_peak = Napi::Array::New(env);

 				for (size_t j = 0; j < item->magnitude.size(); j++) {
-					magnitude.Set(j, Napi::Number::New(env, item->magnitude[j]));
+					magnitude.Set(static_cast<uint32_t>(j), Napi::Number::New(env, item->magnitude[j]));


We could have made the loop variable a uint32_t to avoid the static_cast but I'm not sure how big of an improvement it would be since the uint32_t will just wrap around if we were to go past UINT32_MAX which can be quite a pain. But I'm assuming this code never goes past that limit.

Example:

for (uint32_t j = 0; j < item->magnitude.size(); j++) {

Fair point, I just left the size_t as that's what .size() returns and used the cast on the line with the warning.

sandboxcoder

I left some comments but I think they are all trivial (?) thanks this looks good. Big improvement

Fix compiler warnings

d7b3fd5

Fixes for compiler warnings. The majority were mismatched types and some uninitialized variables. Added flags to suppress some deprecation/security warnings. Remove commented out line More compiler warning fixes Added some Intellisense warnings.

mhoyer-streamlabs force-pushed the fix-compiler-warnings branch from b7b32c1 to d7b3fd5 Compare March 17, 2025 15:52

Missed a couple changes

9643f1c

sandboxcoder reviewed Mar 18, 2025

View reviewed changes

sandboxcoder approved these changes Mar 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix compiler warnings #1507

Fix compiler warnings #1507

mhoyer-streamlabs commented Mar 17, 2025

sandboxcoder Mar 18, 2025 •

edited

Loading

mhoyer-streamlabs Mar 18, 2025

sandboxcoder Mar 18, 2025

sandboxcoder Mar 18, 2025

sandboxcoder Mar 18, 2025

sandboxcoder Mar 18, 2025

mhoyer-streamlabs Mar 18, 2025

sandboxcoder Mar 18, 2025

sandboxcoder Mar 18, 2025

sandboxcoder Mar 18, 2025

sandboxcoder Mar 18, 2025

sandboxcoder Mar 18, 2025

mhoyer-streamlabs Mar 18, 2025

sandboxcoder left a comment

Fix compiler warnings #1507

Are you sure you want to change the base?

Fix compiler warnings #1507

Conversation

mhoyer-streamlabs commented Mar 17, 2025

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

sandboxcoder Mar 18, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sandboxcoder left a comment

Choose a reason for hiding this comment

sandboxcoder Mar 18, 2025 •

edited

Loading