Fix compiler warnings #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type issues, variable initialization, and can't std::move a const
|
|
summeroff
approved these changes
Mar 18, 2025
| @@ -157,15 +157,16 @@ std::vector<ipc::value> ipc::client_win::call_synchronous_helper(const std::stri | |||
| const auto total_time = (std::chrono::high_resolution_clock::now() - cd.start); | |||
| if (!freeze_flagged && total_time > freeze_timeout) { | |||
| freeze_flagged = true; | |||
| m_freeze_cb(m_app_state_path, cname + "::" + fname, std::chrono::duration_cast<std::chrono::milliseconds>(total_time).count(), -1); | |||
| int64_t ms = std::chrono::duration_cast<std::chrono::milliseconds>(total_time).count(); | |||
| m_freeze_cb(m_app_state_path, cname + "::" + fname, static_cast<int>(ms), -1); | |||
There was a problem hiding this comment.
(Trivial) I realize this is legacy code but this code is likely creating temporary strings? maybe we could consider like this in the future but perhaps this alternative is less readable I admit.
cname.append("::").append(fname)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type issues, variable initialization, and can't std::move a const