[Highlighter] - Ui update export flow #5328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/services/highlighter/index.ts # app/services/highlighter/models/ai-highlighter.models.ts
gettinToasty
requested changes
Mar 21, 2025
| @@ -108,10 +132,11 @@ function ExportModal({ close, streamId }: { close: () => void; streamId: string | |||
| // Clear all errors when this component unmounts | |||
| useEffect(() => unmount, []); | |||
|
|
|||
| if (exportInfo.exporting) return <ExportProgress />; | |||
| if (!exportInfo.exported) { | |||
| // if (exportInfo.exporting) return <ExportProgress />; | |||
There was a problem hiding this comment.
should this be deleted?
| </div> | ||
| <div style={{ display: 'flex', gap: '16px' }}> | ||
| <div className={styles.settingsAndProgress}> | ||
| <div className={`${styles.pathWrapper} ${isExporting ? styles.isDisabled : ''}`}> |
There was a problem hiding this comment.
we use a library classnames to help with dynamic css classes like this, you can search cx( in our codebase to see some examples
| <FileInput | ||
| label={$t('Export Location')} | ||
| name="exportLocation" | ||
| save={true} |
There was a problem hiding this comment.
if you're using a truthy boolean property you can omit the ={true} :D
| ? { objectPosition: 'left' } | ||
| : { objectPosition: `-${(SCRUB_WIDTH * 1.32) / 3 + 4}px` } | ||
| } | ||
| alt="" |
There was a problem hiding this comment.
not sure why this is here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancellation is not working on prod and therefore also not in this PR.
Will fix that in a separate PR.