Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack extend warning. #2660

Merged
merged 3 commits into from
Jan 5, 2018
Merged

Update webpack extend warning. #2660

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d83d40
Update webpack extend warning.
Alfredo-Delgado Jan 5, 2018
037d89e
Merge branch 'master' into Alfredo-Delgado-patch-1
Alfredo-Delgado Jan 5, 2018
39b4895
Merge branch 'master' into Alfredo-Delgado-patch-1
Hypnosphi Jan 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/pages/configurations/custom-webpack-config/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Since this config file stays in the Storybook directory, you need to set the inc

You also need to install the loaders (style, css, and sass) used in above config manually.

> Once you create this `webpack.config.js` file, Storybook won't load the [default Webpack config](/configurations/default-config/) other than loading JS files with the Babel loader.
> Once you create this `webpack.config.js` file, Storybook won't load the [default Webpack config](/configurations/default-config/) other than loading JS files with the Babel loader. This will disable included functionality like svg loading. Read on to learn how to [retain defaults](#full-control-mode--default).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend mode retains defaults as well

Copy link
Member Author

@Alfredo-Delgado Alfredo-Delgado Jan 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I discovered a regression and the existing documentation contradicts that. This is the existing documentation: Once you create this webpack.config.js file, Storybook won't load the default Webpack config other than loading JS files with the Babel loader. I've only extended it to highlight the kind of functionality that's lost when this happens and link to the better solution down the page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that there's a sense in linking to #extend-mode instead, but now I see that this is already in this section. It's quite weird actually, need to investigate why is it so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nevermind. I actually was wrong and extend mode extends baseConfig, not the default one

### Supported Webpack Options

Expand Down