Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate stories in angular-cli example #2592

Merged
merged 6 commits into from
Dec 28, 2017

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Dec 28, 2017

Issue: Angular examples are located mostly in one file.

What I did

I've extracted a few examples from the index.ts to the separate stories.

PS. This is a cherry-pick from #2564 to make it easier.

@igor-dv igor-dv self-assigned this Dec 28, 2017
@igor-dv igor-dv added angular maintenance User-facing maintenance tasks labels Dec 28, 2017
@codecov
Copy link

codecov bot commented Dec 28, 2017

Codecov Report

Merging #2592 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2592   +/-   ##
=======================================
  Coverage   32.61%   32.61%           
=======================================
  Files         397      397           
  Lines        8855     8855           
  Branches      961      954    -7     
=======================================
  Hits         2888     2888           
+ Misses       5296     5294    -2     
- Partials      671      673    +2
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/actions/src/lib/types/symbol/index.js 81.25% <0%> (ø) ⬆️
lib/components/src/table/cell.js 65.21% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 50% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 51.85% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReplacer.js 54.54% <0%> (ø) ⬆️
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/addon_panel/index.js 34.78% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/shortcuts_help.js 25% <0%> (ø) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce993cc...469ecb1. Read the comment docs.

@ndelangen ndelangen merged commit 03f04e0 into master Dec 28, 2017
@ndelangen ndelangen deleted the angular-cli-stories-separation branch December 28, 2017 23:26
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 7, 2018
@shilman
Copy link
Member

shilman commented Jan 7, 2018

adding this to patch release to satisfy dependency in #2646

shilman pushed a commit that referenced this pull request Jan 7, 2018
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants