-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate stories in angular-cli example #2592
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2592 +/- ##
=======================================
Coverage 32.61% 32.61%
=======================================
Files 397 397
Lines 8855 8855
Branches 961 954 -7
=======================================
Hits 2888 2888
+ Misses 5296 5294 -2
- Partials 671 673 +2
Continue to review full report at Codecov.
|
ndelangen
approved these changes
Dec 28, 2017
adding this to patch release to satisfy dependency in #2646 |
shilman
pushed a commit
that referenced
this pull request
Jan 7, 2018
Separate stories in angular-cli example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
angular
maintenance
User-facing maintenance tasks
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Angular examples are located mostly in one file.
What I did
I've extracted a few examples from the
index.ts
to the separate stories.PS. This is a cherry-pick from #2564 to make it easier.