Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin glob dep to 10.1.0 #24002

Closed
wants to merge 1 commit into from
Closed

Pin glob dep to 10.1.0 #24002

wants to merge 1 commit into from

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 30, 2023

Closes #22171 (comment)

What I did

Glob 10.2 and above adds some problematic dependencies which contain ESM-only code that trips up some node tooling including Jest and ESlint. Pinning this to an older version for now.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

TBD. @tmeasday @yannbf do you know how to test this?

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@shilman shilman added dependencies patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Aug 30, 2023
@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @shilman. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/6021287683

@tmeasday
Copy link
Member

I don't think this will work as we have indirect dependencies on glob. You can see them in our yarn lock

@github-actions
Copy link
Contributor

Fails
🚫 PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter Good examples: - "Docs: Describe Canvas Doc Block" - "Svelte: Support Svelte v4" Bad examples: - "add new api docs" - "fix: Svelte 4 support" - "Vue: improve docs"

Generated by 🚫 dangerJS against c993eec

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
glob 10.1.0 None +0 419 kB isaacs

@shilman shilman closed this Aug 30, 2023
@shilman shilman mentioned this pull request Aug 30, 2023
5 tasks
@IanVS IanVS deleted the shilman/pin-glob-deps branch August 30, 2023 10:26
@IanVS
Copy link
Member

IanVS commented Aug 30, 2023

Sorry, didn't mean to delete the branch. Am on my phone and tapped it accidentally.

@IanVS
Copy link
Member

IanVS commented Aug 30, 2023

I created a fresh vite-storybook package, and found that the only globby in my yarn.lock were from storybook packages directly or from del, which is brought in by @storybook/cli via tempy. It seems like a potential solution might be pinning the version used by storybook and then finding some solution for tempy (I'm not sure what it's used for, or whether there's an alternative or version that we could pin to that would work).

@IanVS
Copy link
Member

IanVS commented Aug 30, 2023

My mistake, I guess I wasn't fully awake, this is about glob, and not globby. Ignore what I said above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal dependencies patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants