-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin glob dep to 10.1.0 #24002
Pin glob dep to 10.1.0 #24002
Conversation
Failed to publish canary version of this pull request, triggered by @shilman. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/6021287683 |
I don't think this will work as we have indirect dependencies on glob. You can see them in our yarn lock |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sorry, didn't mean to delete the branch. Am on my phone and tapped it accidentally. |
I created a fresh vite-storybook package, and found that the only |
My mistake, I guess I wasn't fully awake, this is about |
Closes #22171 (comment)
What I did
Glob 10.2 and above adds some problematic dependencies which contain ESM-only code that trips up some node tooling including Jest and ESlint. Pinning this to an older version for now.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
TBD. @tmeasday @yannbf do you know how to test this?
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>