Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made jest test file extension name optional #2373

Merged
merged 2 commits into from
Nov 25, 2017
Merged

Made jest test file extension name optional #2373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8565613
Made jest test file extension name optional
promisetochi Nov 25, 2017
0803483
Merge branch 'master' into master
Hypnosphi Nov 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/jest/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import addons from '@storybook/addons';

const findTestResults = (testFiles, jestTestResults, jestTestFilesExt) =>
const findTestResults = (testFiles, jestTestResults, jestTestFilesExt = "") =>
Copy link
Member

@Hypnosphi Hypnosphi Nov 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you ran git commit --no-verify instead of just git commit? We have a git hook which runs eslint in "fix" mode, which would replace those double quotes with single ones

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely didn't do yarn install, it's OK, we'll do a fix commit soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll run yarn lint:js --fix after merging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, noticed the double quotes after commiting, thanks!

testFiles.map(name => {
if (jestTestResults && jestTestResults.testResults) {
return {
Expand Down