Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot for closing old issues #2186

Merged
merged 3 commits into from
Oct 31, 2017
Merged

bot for closing old issues #2186

merged 3 commits into from
Oct 31, 2017

Conversation

danielduan
Copy link
Member

@danielduan danielduan commented Oct 31, 2017

Issue:

#1138
As discussed in our roadmap meetings, the number of issues we get is getting out of hand and manually closing stale issues is very time consuming. I hope this bot will help us out.

What I did

This is a bot from https://probot.github.io/apps/stale/

The config I have here is a bit more conservative in my opinion. 45 days for a stale message and another 45 days until issue close. We can also add labels that are excluded from automatically getting closed.

Any opinions?

How to test

Is this testable with jest or storyshots?
no
Does this need a new example in the kitchen sink apps?
no
Does this need an update to the documentation?
maybe? should the 90 days be documented?
If your answer is yes to any of these, please make sure to include it in your PR.

@danielduan danielduan requested review from shilman, ndelangen and a team October 31, 2017 01:35
@codecov-io
Copy link

codecov-io commented Oct 31, 2017

Codecov Report

Merging #2186 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2186   +/-   ##
=======================================
  Coverage   21.43%   21.43%           
=======================================
  Files         263      263           
  Lines        5803     5803           
  Branches      697      698    +1     
=======================================
  Hits         1244     1244           
+ Misses       4038     4008   -30     
- Partials      521      551   +30
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.63% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 32% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 9.09% <0%> (ø) ⬆️
addons/info/src/components/Node.js 39.7% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 21% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7709161...b58fb8b. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielduan
Copy link
Member Author

danielduan commented Oct 31, 2017

I'm gonna set this bot at 85 days for stale + 5 more to close for now. This will help us clear the backlog of really old issues. When that's done, I will put it back to the more reasonable 45 + 45 and we'll adjust as needed.

@danielduan danielduan merged commit efdf9f0 into master Oct 31, 2017
@danielduan danielduan deleted the dd/issue-bot branch October 31, 2017 02:41
@ndelangen
Copy link
Member

This is awesome, just what we need!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants