Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with code 1 if start-storybook --smoke-test fails #1851

Merged
merged 2 commits into from
Sep 15, 2017

Conversation

Hypnosphi
Copy link
Member

Issue: If a compile error happens when running start-storybook, it doen't exit so that user is able to fix the error without relaunching the command. This makes smoke tests hang on errors, e.g. https://circleci.com/gh/storybooks/storybook/11910

How to test

  • Make an error in examples/cra-kitchen-sink/.storybook/config.js
  • run yarn start --smoke-test

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 15, 2017

Codecov Report

Merging #1851 into release/3.3 will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #1851      +/-   ##
===============================================
- Coverage        22.27%   22.25%   -0.02%     
===============================================
  Files              324      324              
  Lines             6335     6339       +4     
  Branches           801      796       -5     
===============================================
  Hits              1411     1411              
- Misses            4322     4332      +10     
+ Partials           602      596       -6
Impacted Files Coverage Δ
app/react/src/server/index.js 0% <0%> (ø) ⬆️
app/vue/src/server/index.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 41.41% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 50.74% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/info/src/components/types/OneOfType.js 11.11% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 22.22% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93c4e1...771c72d. Read the comment docs.

@Hypnosphi Hypnosphi merged commit fa3adf6 into release/3.3 Sep 15, 2017
@Hypnosphi Hypnosphi deleted the exit-1-smoke-tests branch September 15, 2017 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants