Exit with code 1 if start-storybook --smoke-test
fails
#1851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: If a compile error happens when running
start-storybook
, it doen't exit so that user is able to fix the error without relaunching the command. This makes smoke tests hang on errors, e.g. https://circleci.com/gh/storybooks/storybook/11910How to test
examples/cra-kitchen-sink/.storybook/config.js
yarn start --smoke-test