-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dependencies.io Lerna support & disable issue creation #1803
Conversation
Codecov Report
@@ Coverage Diff @@
## release/3.3 #1803 +/- ##
============================================
Coverage 22.24% 22.24%
============================================
Files 325 325
Lines 6522 6522
Branches 831 832 +1
============================================
Hits 1451 1451
+ Misses 4448 4425 -23
- Partials 623 646 +23
Continue to review full report at Codecov.
|
why based on 3.3 ?. |
master doesn't have |
After a discussion in slack, I disabled issue creators:
|
dependencies.yml
Outdated
- type: js-lerna | ||
path: / | ||
settings: | ||
bootstrap_command: yarn && yarn bootstrap -- --core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to hold this until #1810
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll add both to 3.3 milestone (see #1803 (comment))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, the command has to stay the same: the bootstrap script won't work without root depandencies
Ok, just to get everything clear:
|
Both true |
I don't think I understand what's going on here: https://circleci.com/gh/storybooks/storybook/12142?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
I think the best way to proceed with this, is to get yarn-workspaces and yarn lock files on master and get this merged to master. What do you think @Hypnosphi @shilman @igor-dv @storybooks/team ? Greenkeeper has already been disabled for the entire organisation |
I will do that as long as everyone is OK with it |
seems reasonable to me. This is a developer oriented change so merging to master wouldn't really affect the product itself. |
@Hypnosphi Can you make the PR? I think it's a go. |
Should it be one PR for |
Let's do yarn & workspaces first, and then dependencies.io after |
See Hypnosphi#85