Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in storybook common components refactor #1302

Closed
wants to merge 1 commit into from

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 17, 2017

Issue: #1266

What I did

Fixed bug in components refactor. Now getstorybook needs to add a @storybook/components dependency when it runs, otherwise the components are not found.

How to test

yarn install && yarn bootstrap
cd ..
yarn create react-app testapp
cd testapp
../storybook/lib/cli/bin/generate.js
yarn storybook
open http://localhost:9009

@shilman shilman added cleanup Minor cleanup style change that won't show up in release changelog bug and removed cleanup Minor cleanup style change that won't show up in release changelog labels Jun 17, 2017
@codecov
Copy link

codecov bot commented Jun 17, 2017

Codecov Report

Merging #1302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1302   +/-   ##
=======================================
  Coverage   13.76%   13.76%           
=======================================
  Files         201      201           
  Lines        4620     4620           
  Branches      506      582   +76     
=======================================
  Hits          636      636           
+ Misses       3538     3483   -55     
- Partials      446      501   +55
Impacted Files Coverage Δ
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 0% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/info/src/components/Props.js 0% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 38.57% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f98ae9...ba5a43e. Read the comment docs.

@shilman
Copy link
Member Author

shilman commented Jun 17, 2017

Reverting and trying another way

@shilman shilman closed this Jun 17, 2017
@Hypnosphi Hypnosphi deleted the fix-getstorybook-components branch October 11, 2017 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants