Process proto2 optional label #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm tempted to remove these dependencies all together because at this point ts-proto has many different flags that can change whether the generated code actually does/does not use certain dependencies. I.e. users using the "only types" output probably don't want ts-proto to bring in any dependencies. I guess in that case, they could be using ts-proto as a devDependency. Fixes stephenh#147.
This reverts commit da5f10a.
stephenh
force-pushed
the
main
branch
4 times, most recently
from
cdf2835 to
7017d4c
Compare
zfy0701
added a commit
to sentioxyz/ts-proto
that referenced
this pull request
Jan 5, 2023
…pace, other adjustments (stephenh#158)
|
A lot of proto2 optional work just landed in #1007 , so going to close this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optionallabel for proto2 should be optional property in Typescript.