Skip to content

Commit

Permalink
chore(node12): remove node 12 from new workflows (#3344)
Browse files Browse the repository at this point in the history
in #3332, new reusable
workflows were created for stencil's ci system to enable
parallelism/speed. these workflows were written with stencil v2 in mind,
and as a result target node v12. we removed v12 support for stencil
(v3+) in #3302. however, upon
merging `main` into `v3.0.0-dev`, we realized that we need to remove the
values for node 12 from the new workflows
  • Loading branch information
rwaskiewicz committed Oct 3, 2022
1 parent e363ea6 commit c6b8ded
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['12', '14', '16']
os: ['ubuntu-latest', 'windows-latest']
node: [ '14', '16' ]
os: [ 'ubuntu-latest', 'windows-latest' ]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout Code
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['12', '14', '16']
os: ['ubuntu-latest', 'windows-latest']
node: [ '14', '16' ]
os: [ 'ubuntu-latest', 'windows-latest' ]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout Code
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['12', '14', '16']
os: ['ubuntu-latest', 'windows-latest']
node: [ '14', '16' ]
os: [ 'ubuntu-latest', 'windows-latest' ]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout Code
Expand Down

0 comments on commit c6b8ded

Please sign in to comment.