chore(types): propagate ValidatedConfig for outputTargets (#3585)

this commit propagates the `ValidatedConfig` type to areas of the
codebase that drops the number of `strictNullChecks` violations related
to the `outputTargets` field.

this commit does not update subfield-related violations of an
`OutputTarget` subtype.

src/compiler/bundle/server-plugin.ts

@@ -4,7 +4,7 @@ import type { Plugin } from 'rollup';
 import { isOutputTargetHydrate } from '../output-targets/output-utils';
 import { isAbsolute } from 'path';
 
-export const serverPlugin = (config: d.Config, platform: string): Plugin => {
+export const serverPlugin = (config: d.ValidatedConfig, platform: string): Plugin => {
   const isHydrateBundle = platform === 'hydrate';
   const serverVarid = `@removed-server-code`;
 

src/compiler/output-targets/output-lazy-loader.ts

@@ -4,7 +4,7 @@ import { isOutputTargetDistLazyLoader, relativeImport } from './output-utils';
 import { join, relative } from 'path';
 import { generatePreamble, normalizePath } from '@utils';
 
-export const outputLazyLoader = async (config: d.Config, compilerCtx: d.CompilerCtx) => {
+export const outputLazyLoader = async (config: d.ValidatedConfig, compilerCtx: d.CompilerCtx) => {
   const outputTargets = config.outputTargets.filter(isOutputTargetDistLazyLoader);
   if (outputTargets.length === 0) {
     return;
@@ -14,7 +14,7 @@ export const outputLazyLoader = async (config: d.Config, compilerCtx: d.Compiler
 };
 
 const generateLoader = async (
-  config: d.Config,
+  config: d.ValidatedConfig,
   compilerCtx: d.CompilerCtx,
   outputTarget: d.OutputTargetDistLazyLoader
 ) => {

src/compiler/plugin/plugin.ts

@@ -58,7 +58,7 @@ export const runPluginLoad = async (pluginCtx: PluginCtx, id: string) => {
 };
 
 export const runPluginTransforms = async (
-  config: d.Config,
+  config: d.ValidatedConfig,
   compilerCtx: d.CompilerCtx,
   buildCtx: d.BuildCtx,
   id: string,

src/compiler/style/global-styles.ts

@@ -5,7 +5,11 @@ import { isOutputTargetDistGlobalStyles } from '../output-targets/output-utils';
 import { optimizeCss } from './optimize-css';
 import { runPluginTransforms } from '../plugin/plugin';
 
-export const generateGlobalStyles = async (config: d.Config, compilerCtx: d.CompilerCtx, buildCtx: d.BuildCtx) => {
+export const generateGlobalStyles = async (
+  config: d.ValidatedConfig,
+  compilerCtx: d.CompilerCtx,
+  buildCtx: d.BuildCtx
+) => {
   const outputTargets = config.outputTargets.filter(isOutputTargetDistGlobalStyles);
   if (outputTargets.length === 0) {
     return;
@@ -17,7 +21,7 @@ export const generateGlobalStyles = async (config: d.Config, compilerCtx: d.Comp
   }
 };
 
-const buildGlobalStyles = async (config: d.Config, compilerCtx: d.CompilerCtx, buildCtx: d.BuildCtx) => {
+const buildGlobalStyles = async (config: d.ValidatedConfig, compilerCtx: d.CompilerCtx, buildCtx: d.BuildCtx) => {
   let globalStylePath = config.globalStyle;
   if (!globalStylePath) {
     return null;
@@ -65,7 +69,7 @@ const buildGlobalStyles = async (config: d.Config, compilerCtx: d.CompilerCtx, b
   return null;
 };
 
-const canSkipGlobalStyles = async (config: d.Config, compilerCtx: d.CompilerCtx, buildCtx: d.BuildCtx) => {
+const canSkipGlobalStyles = async (config: d.ValidatedConfig, compilerCtx: d.CompilerCtx, buildCtx: d.BuildCtx) => {
   if (!compilerCtx.cachedGlobalStyle) {
     return false;
   }
@@ -104,7 +108,7 @@ const canSkipGlobalStyles = async (config: d.Config, compilerCtx: d.CompilerCtx,
 };
 
 const hasChangedImportFile = async (
-  config: d.Config,
+  config: d.ValidatedConfig,
   compilerCtx: d.CompilerCtx,
   buildCtx: d.BuildCtx,
   filePath: string,
@@ -120,7 +124,7 @@ const hasChangedImportFile = async (
 };
 
 const hasChangedImportContent = async (
-  config: d.Config,
+  config: d.ValidatedConfig,
   compilerCtx: d.CompilerCtx,
   buildCtx: d.BuildCtx,
   filePath: string,

src/compiler/transpile/run-program.ts

@@ -12,7 +12,7 @@ import { updateStencilTypesImports } from '../types/stencil-types';
 import { validateTranspiledComponents } from './validate-components';
 
 export const runTsProgram = async (
-  config: d.Config,
+  config: d.ValidatedConfig,
   compilerCtx: d.CompilerCtx,
   buildCtx: d.BuildCtx,
   tsBuilder: ts.BuilderProgram

src/testing/testing-utils.ts

@@ -62,20 +62,20 @@ export function expectFilesDoNotExist(fs: InMemoryFileSystem, filePaths: string[
   }
 }
 
-export function getAppScriptUrl(config: d.Config, browserUrl: string) {
+export function getAppScriptUrl(config: d.ValidatedConfig, browserUrl: string) {
   const appFileName = `${config.fsNamespace}.esm.js`;
   return getAppUrl(config, browserUrl, appFileName);
 }
 
-export function getAppStyleUrl(config: d.Config, browserUrl: string) {
+export function getAppStyleUrl(config: d.ValidatedConfig, browserUrl: string) {
   if (config.globalStyle) {
     const appFileName = `${config.fsNamespace}.css`;
     return getAppUrl(config, browserUrl, appFileName);
   }
   return null;
 }
 
-function getAppUrl(config: d.Config, browserUrl: string, appFileName: string) {
+function getAppUrl(config: d.ValidatedConfig, browserUrl: string, appFileName: string) {
   const wwwOutput = config.outputTargets.find(isOutputTargetWww);
   if (wwwOutput) {
     const appBuildDir = wwwOutput.buildDir;

src/utils/util.ts

@@ -96,7 +96,7 @@ export const hasDependency = (buildCtx: d.BuildCtx, depName: string): boolean =>
 
 export const getDynamicImportFunction = (namespace: string) => `__sc_import_${namespace.replace(/\s|-/g, '_')}`;
 
-export const readPackageJson = async (config: d.Config, compilerCtx: d.CompilerCtx, buildCtx: d.BuildCtx) => {
+export const readPackageJson = async (config: d.ValidatedConfig, compilerCtx: d.CompilerCtx, buildCtx: d.BuildCtx) => {
   try {
     const pkgJson = await compilerCtx.fs.readFile(config.packageJsonFilePath);