-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 - Horizon 1.0 support #488
Conversation
f434623
to
91df1c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor copy edits. Otherwise, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Minor comments
…transaction-helpers-sep-10 * upstream/master: Fix broken link to Stellar logo+wordmark (stellar#496) Junk the _link omition for AccountResponse class (stellar#495) v4.0.0 - Horizon 1.0 support (stellar#488) Add is_authorized to BalanceLineAsset. (stellar#491) Update yarn.lock. (stellar#490) Typescript fixes (stellar#489)
Added
Add support for top-level offers endpoint with
seller
,selling
, andbuying
filter. (#485)Horizon 1.0 includes a new
/offers
end-point, which allows you to list all offers, supporting filtering byseller
,selling asset
, orbuying asset
.You can fetch data from this endpoint by doing
server.offers()
and use any of the following filters:seller
:server.offers().accountId(accountId)
buying
:server.offers().buying(asset)
selling
:server.offers().selling(asset)
This introduced a breaking change since it modified the signature for the function
server.offers()
.Before if you wanted to list all the offers for a given account, you'd do:
Starting on this version you'll need to do:
You can do now things that were not possible before, like finding
all offers for an account filtering by the selling or buying asset
Add support for filtering accounts by
signer
orasset
(#474)Horizon 1.0 includes a new
/accounts
end-point, which allows you to list all accounts who have another account as a signer or hold a given asset.You can fetch data from this endpoint by doing
server.accounts()
and use any of the following filters:accountID
:server.accounts().accountId(accountId)
, returns a single account.forSigner
:server.accounts().forSigner(accountId)
, returns accounts whereaccountId
is a signer.forAsset
:server.accounts().forAsset(asset)
, returns accounts which hold theasset
.Add TypeScript typings for new fields in
fee_stats
. (#462)Changed
Fixed
Breaking
Remove
fee_paid
field from transaction response. (#476)Remove all
*_accepted_fee
from FeeStatsResponse. (#463)Change function signature for
server.offers
. (#485)The signature for the function
server.offers()
was changed to bring suppport for other filters.Before if you wanted to list all the offers for a given account, you'd do:
Starting on this version you'll need to do: