Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: disable Lint/DuplicateBranch #228

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Proposal: disable Lint/DuplicateBranch #228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33407f9
Proposal: disable Lint/DuplicateBranch
rsanheim Dec 3, 2020
5bf3426
add reference to discussion
rsanheim Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,9 @@ Lint/DeprecatedClassMethods:
Lint/DeprecatedOpenSSLConstant:
Enabled: true

# Disabled because it can promote code that is overly DRY at the expense of readability -- see https://github.com/testdouble/standard/pull/228
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record we just delete things from the YAML file when we remove this (I'll fix this in master). Reason being that there are so many rules out there and having to visually parse enabled/disabled stuff or commented rules is just too much work. If someone wants to know the sordid history of a particular cop they can just git log -S DuplicateBranch and find this commit!

Lint/DuplicateBranch:
Enabled: true
Enabled: false

Lint/DuplicateCaseCondition:
Enabled: true
Expand Down