Skip to content

Update to Prometheus v3 #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025
Merged

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Apr 29, 2025

With Kolla bumping Promtheus to v3, the v2 name has been dropped. Updates our tooling to reflect that.

With Kolla bumping Promtheus to v3, the v2 name has been dropped.
Updates our tooling to reflect that.
@MoteHue MoteHue requested a review from a team as a code owner April 29, 2025 14:47
@MoteHue MoteHue changed the title Rename prometheus-v2-server to prometheus-server Update to Prometheus v3 Apr 29, 2025
@MoteHue
Copy link
Contributor Author

MoteHue commented Apr 29, 2025

Will need new prom v3 images, need to deal with the CVEs found: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/14734290496

@MoteHue MoteHue marked this pull request as draft April 29, 2025 15:11
@MoteHue MoteHue force-pushed the fix-prometheus-server-image-builds branch from db1848f to 058dc5e Compare April 30, 2025 09:50
@MoteHue MoteHue force-pushed the fix-prometheus-server-image-builds branch from 058dc5e to 53ac87c Compare April 30, 2025 10:28
@MoteHue MoteHue force-pushed the fix-prometheus-server-image-builds branch from 53ac87c to 91e351a Compare April 30, 2025 11:19
@MoteHue MoteHue marked this pull request as ready for review April 30, 2025 12:33
MoteHue and others added 2 commits April 30, 2025 13:43
CVE-2024-45337 [1] affects multiple Prometheus containers. The
vulnerability allows for authorisation bypassing due to a flaw in the
handling of public key handling. We only access Prometheus with basic
auth (username/password), so we are not affected by this CVE.

CVE-2024-41110 [2] only affects prometheus_cadvisor. Suggested
workarounds are to avoid using AuthZ plugins and/or restrict access to
the Docker API to trusted parties. Best I can tell, we don't use any
AuthZ plugins and regardless the Docker API can only be reached from
the control plane, as we are not affected by this CVE.

1. https://avd.aquasec.com/nvd/2024/cve-2024-45337/
2. https://avd.aquasec.com/nvd/2024/cve-2024-41110/
@MoteHue MoteHue force-pushed the fix-prometheus-server-image-builds branch from f150e92 to 598e0ed Compare April 30, 2025 12:43
Alex-Welsh
Alex-Welsh previously approved these changes Apr 30, 2025
@MoteHue MoteHue force-pushed the fix-prometheus-server-image-builds branch from 598e0ed to 898cfc1 Compare April 30, 2025 13:02
@MoteHue
Copy link
Contributor Author

MoteHue commented Apr 30, 2025

@MoteHue MoteHue requested a review from Alex-Welsh April 30, 2025 13:37
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade job failed because #1620 hasn't merged yet. LGTM

@Alex-Welsh Alex-Welsh merged commit 175d981 into stackhpc/master Apr 30, 2025
12 of 13 checks passed
@Alex-Welsh Alex-Welsh deleted the fix-prometheus-server-image-builds branch April 30, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants