Skip to content

feat: add support for TLS generation with OpenBao #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: stackhpc/2024.1
Choose a base branch
from

Conversation

jackhodgkiss
Copy link
Contributor

No description provided.

@jackhodgkiss jackhodgkiss self-assigned this Apr 24, 2025
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner April 24, 2025 15:53
@product-auto-label product-auto-label bot added size: xl ansible Ansible playbooks documentation Improvements or additions to documentation labels Apr 24, 2025
@jovial
Copy link
Contributor

jovial commented Apr 24, 2025

Should we deprecate hashicorp vault and refer people to the openbao page? I know there is some duplication between the playbooks, but I don't see a massive problem if we remove support for vault in the near future. Any migration path for your old data?

@jackhodgkiss
Copy link
Contributor Author

Should we deprecate hashicorp vault and refer people to the openbao page? I know there is some duplication between the playbooks, but I don't see a massive problem if we remove support for vault in the near future. Any migration path for your old data?

I think for all new deployments we should use OpenBao. It terms of migrating from vault to openbao I think TLS could be discarded and you still deploy from scratch say in the run up to a certificate replacement. However the problem is Barbican that data is valuable and should be imported.

My understanding though I haven't tested is OpenBao should be an inplace upgrade of the container image. Though we need to handle the different configuration file and docker volumes. Something that could be tested in a AIO.

@jovial
Copy link
Contributor

jovial commented Apr 25, 2025

My understanding though I haven't tested is OpenBao should be an inplace upgrade of the container image. Though we need to handle the different configuration file and docker volumes. Something that could be tested in a AIO.

Sounds promising. I'd suggest adding a notice in the vault docs noting that it is deprecated and new deployments should use OpenBao (also worth mentioning it in the release note). We can add the migration procedure once we have worked it out :)

@jackhodgkiss jackhodgkiss requested a review from jovial April 25, 2025 13:10
@mnasiadka
Copy link
Member

I think we need some more write up why do we need to duplicate all playbooks - in theory we use the same client. Can't we just update the vault playbooks with some variables when openbao is enabled?

@jackhodgkiss
Copy link
Contributor Author

I think we need some more write up why do we need to duplicate all playbooks - in theory we use the same client. Can't we just update the vault playbooks with some variables when openbao is enabled?

I decided to clone the playbooks so there is clear distinction between Vault and OpenBao I think it would be confusing to some that the playbook for deploying OpenBao is called vault-deploy-overcloud.yml. We also want to deprecate the use of Vault all together so at some point the vault functionaility would have to be removed it seems it would be easier to do so if they were kept as separate playbooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Ansible playbooks documentation Improvements or additions to documentation size: xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants