Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support of electra fork #2007

Open
wants to merge 24 commits into
base: stage
Choose a base branch
from
Open

feat: support of electra fork #2007

wants to merge 24 commits into from

Conversation

MatusKysel
Copy link
Contributor

@MatusKysel MatusKysel commented Jan 29, 2025

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 16.73307% with 209 lines in your changes missing coverage. Please review.

Project coverage is 47.6%. Comparing base (0f48bb6) to head (91f2469).
Report is 4 commits behind head on stage.

Files with missing lines Patch % Lines
beacon/goclient/aggregator.go 0.0% 77 Missing ⚠️
beacon/goclient/proposer.go 0.0% 60 Missing ⚠️
beacon/goclient/dataversion.go 38.8% 43 Missing and 12 partials ⚠️
beacon/goclient/goclient.go 6.2% 13 Missing and 2 partials ⚠️
beacon/goclient/attest.go 75.0% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatusKysel MatusKysel marked this pull request as ready for review January 30, 2025 12:59
@MatusKysel MatusKysel changed the title feat: initial implementation of electra fork feat: support of electra fork Jan 30, 2025
return spec.DataVersionElectra
}

func fetchStaticValues(gc *GoClient) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively we could have it as a method on the *GoClient like we do above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but I wanted to be private for now there is big PR coming that will do this more nicer way, getting all data dynamically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants