-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support of electra fork #2007
base: stage
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
beacon/goclient/dataversion.go
Outdated
return spec.DataVersionElectra | ||
} | ||
|
||
func fetchStaticValues(gc *GoClient) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively we could have it as a method on the *GoClient
like we do above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but I wanted to be private for now there is big PR coming that will do this more nicer way, getting all data dynamically
https://hackmd.io/p2v3-l1GTjmk3nVikKxzcQ?view