Skip to content

Commit

Permalink
Fix actions\build to use mvn help:evaluate
Browse files Browse the repository at this point in the history
Since there is no `revision` property in POM, we cannot use `sed` command to extract project version from the POM.

* Use more Maven-friendly `mvn help:evaluate -Dexpression="project.version" -q -DforceStdout` command to get the current project version
* Remove tentative `finish_release_tmp.yml` since `actions\build` has been fixed now
  • Loading branch information
artembilan committed Dec 13, 2024
1 parent 6cb5d7a commit 72a0d0e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 30 deletions.
2 changes: 1 addition & 1 deletion .github/actions/build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ runs:
id: read-version
shell: bash
run: |
version=$(sed -n 's/^.*<revision>\(.*\)<\/revision>.*$/\1/p' pom.xml)
version=$(mvn help:evaluate -Dexpression="project.version" -q -DforceStdout)
echo "Version is $version"
echo "version=$version" >> $GITHUB_OUTPUT
29 changes: 0 additions & 29 deletions .github/workflows/finish_release_tmp.yml

This file was deleted.

0 comments on commit 72a0d0e

Please sign in to comment.