Fix UnsupportedOperationException for duplicate keys in AddRequestHeader with ModifyRequestBody #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der with ModifyRequestBody.
|
What versions are you using? |
4.1.5. In the new version, it's unclear whether this issue exists if StrictServerWebExchangeFirewall is not introduced (I haven't verified it yet). |
|
The latest versions of spring boot have the fixes for the underlying read only headers problem. What version of boot are you using? |
spring boot 3.2.12, springframework 6.1.15. @spencergibb I noticed it in gh-33666,, and it happens to not be fixed in the 6.1.x version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @spencergibb,
I recently discovered an issue when using
ModifyRequestBodyGatewayFilterFactoryandAddRequestHeaderGatewayFilterFactorytogether. IfModifyRequestBodyis executed first, the header value will be aListof typeunmodifiable. IfAddRequestHeaderthen tries to add a key that already exists, it will throw anUnsupportedOperationException.I tried modifying putAll to addAll in ModifyRequestBodyGatewayFilterFactory, and this is likely to resolve the issue.