Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum values to config properties docs #3661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abelsromero
Copy link
Contributor

We recently looked into pool configurations and found references to configuration values not in the docs.
This PR simply adds the enum values so there's no need to look into the code.
Updated

  • httpclient.pool.leasing-strategy
  • httpclient.pool.type
  • httpclient.proxy.type

Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should go in the configprops class or metadata file as this will be overwritten by a build

@abelsromero abelsromero force-pushed the add-enum-values-to-properties-docs branch from 96143e6 to 715a5fe Compare January 24, 2025 08:37
@abelsromero
Copy link
Contributor Author

Thanks, updated the JavaDocs in the source class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants