Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tooltip): remove side before and after slide classes #93

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

elite-benni
Copy link
Collaborator

side of before and after is translated to left and right accordingly to direction. Nothing to do here, because it already works as intended with left and right.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • button
  • calendar
  • card
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • hover-card
  • input
  • label
  • menubar
  • navigation-menu
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • switch
  • table
  • tabs
  • textarea
  • toast
  • toggle
  • tooltip
  • typography

What is the current behavior?

A Todo comment is in the source to fix rtl direction animation slide in of the tooltip

What is the new behavior?

The Todo is removed, because it is nothing to do.
Also the data-[side=after] and data-[side=before] are removed, as they are translated to left and right.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

side of before and after is translated to left and right accordingly to direction.
Nothing to do here, because it already works as intended with left and right.
@goetzrobin goetzrobin merged commit afb596c into spartan-ng:main Jan 2, 2024
6 checks passed
@elite-benni elite-benni deleted the rtlTooltip branch January 2, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants