Updated protobuf and py-protobuf to version 3.6.1 #9536
Conversation
also updated the download link as the repository has moved
| @@ -53,7 +54,7 @@ class Protobuf(CMakePackage): | |||
|
|
|||
| depends_on('zlib') | |||
|
|
|||
| conflicts('%gcc@:4.6') # Requires c++11 | |||
| conflicts('%gcc@:4.6', when='@3.6.0:') # Requires c++11 | |||
|
|
|||
There was a problem hiding this comment.
Why does this only apply to versions >= 3.6 when it previously applied to all versions?
There was a problem hiding this comment.
The protobuf release page states that c++11 is only required from version 3.6 onward. In particular it says
Starting from this release, we now require C++11. For those we cannot yet upgrade to C++11, we will try to keep the 3.5.x branch updated with critical bug fixes only. If you have any concerns about this, please comment on issue protocolbuffers/protobuf#2780.
I have to admit that I didn't bother to check why someone added that conflict in the first place. I have now stumbled across #3948 where the conflict was added but it doesn't really make sense to me. If the build really fails because of a gcc version < 4.6 and c++11 is the reason someone should probably inform the protobuf developers about that.
There was a problem hiding this comment.
If the build really fails because of a gcc version ...
Can we try this before we lower the restriction? :)
There was a problem hiding this comment.
Can we try this before we lower the restriction? :)
I will try it :)
There was a problem hiding this comment.
Turns out it is not really trivial to do spack install [email protected] maybe someone should rework that package as well :(
I will keep trying :)
There was a problem hiding this comment.
Yes, I know. Installing older GCC with newer GCC releases turns out to be non-trivial, since usually one would only do it the other way around 🙈
There was a problem hiding this comment.
I tested with a [email protected] on a centos6 and it works for all versions of the package except 3.2.0, 3.3.0 and as expected 3.6.1 (c++11). I will modify the conflict accordingly soon.
I'm going to tack |
|
I have modified the conflict :) sorry that it took so long |
|
@scheibelp I seem to be unable to remove the |
also updated the download link as the repository has moved