Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test for querying undefined field #544

Merged
merged 1 commit into from
Jun 21, 2022
Merged

test: Add test for querying undefined field #544

merged 1 commit into from
Jun 21, 2022

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #411

Description

Adds test for querying undefined field.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

Specify the platform(s) on which this was tested:

  • Debian Linux

@AndrewSisley AndrewSisley added area/query Related to the query component area/testing Related to any test or testing suite action/no-benchmark Skips the action that runs the benchmark. labels Jun 21, 2022
@AndrewSisley AndrewSisley requested a review from a team June 21, 2022 15:24
@AndrewSisley AndrewSisley self-assigned this Jun 21, 2022
fredcarle
fredcarle approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndrewSisley AndrewSisley merged commit 970f887 into develop Jun 21, 2022
@AndrewSisley AndrewSisley deleted the sisley/test/I411-query-undefined-field branch June 21, 2022 16:12
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
test: Add test for querying undefined field (sourcenetwork#544)
6ac9428 
Add test for querying undefined field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

Assignees

@AndrewSisley AndrewSisley

Labels
action/no-benchmark Skips the action that runs the benchmark. area/query Related to the query component area/testing Related to any test or testing suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No tests covering the attempted query of an undefined field
2 participants
@AndrewSisley @fredcarle