-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve log outputs #506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orpheuslummis
added
code quality
Related to improving code quality
action/no-benchmark
Skips the action that runs the benchmark.
labels
Jun 7, 2022
Codecov Report
@@ Coverage Diff @@
## develop #506 +/- ##
========================================
Coverage 65.09% 65.09%
========================================
Files 87 87
Lines 10242 10242
========================================
Hits 6667 6667
Misses 2927 2927
Partials 648 648
|
shahzadlone
reviewed
Jun 7, 2022
shahzadlone
reviewed
Jun 7, 2022
shahzadlone
reviewed
Jun 7, 2022
shahzadlone
approved these changes
Jun 7, 2022
Co-authored-by: Shahzad Lone <[email protected]>
Co-authored-by: Shahzad Lone <[email protected]>
Co-authored-by: Shahzad Lone <[email protected]>
PR name can be: Avoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action/no-benchmark
Skips the action that runs the benchmark.
code quality
Related to improving code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEVANT ISSUE(S)
Resolves #505
DESCRIPTION
Simply improving the log outputs regarding their normalization, capitalization, usage of
log.ErrorE
, etc.HOW HAS THIS BEEN TESTED?
Local and CI.
CHECKLIST:
ENVIRONMENT / OS THIS WAS TESTED ON?
Please specify which of the following was this tested on (remove or add your own):