Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable secondary index for compound filter conditions #3417

Open
wants to merge 70 commits into
base: develop
Choose a base branch
from
+1,924 −750

Fix lint

91ac5a9
Select commit
Loading
Failed to load commit list.
Open

feat: Enable secondary index for compound filter conditions #3417

Fix lint
91ac5a9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 4, 2025 in 0s

78.27% (-0.01%) compared to a2b8971, passed because coverage increased by 0.12% when compared to adjusted base (78.15%)

View this Pull Request on Codecov

78.27% (-0.01%) compared to a2b8971, passed because coverage increased by 0.12% when compared to adjusted base (78.15%)

Details

Codecov Report

Attention: Patch coverage is 92.43697% with 36 lines in your changes missing coverage. Please review.

Project coverage is 78.27%. Comparing base (a2b8971) to head (91ac5a9).

Files with missing lines Patch % Lines
internal/db/fetcher/indexer.go 80.65% 8 Missing and 4 partials ⚠️
internal/db/fetcher/indexer_matchers.go 90.28% 5 Missing and 2 partials ⚠️
internal/db/fetcher/wrapper.go 82.86% 4 Missing and 2 partials ⚠️
internal/db/fetcher/document.go 40.00% 2 Missing and 1 partial ⚠️
internal/db/fetcher/indexer_iterators.go 96.81% 2 Missing and 1 partial ⚠️
internal/planner/type_join.go 97.22% 2 Missing ⚠️
internal/connor/and.go 0.00% 0 Missing and 1 partial ⚠️
internal/connor/in.go 0.00% 0 Missing and 1 partial ⚠️
internal/connor/or.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3417      +/-   ##
===========================================
- Coverage    78.28%   78.27%   -0.01%     
===========================================
  Files          392      393       +1     
  Lines        36045    36106      +61     
===========================================
+ Hits         28217    28260      +43     
- Misses        6163     6185      +22     
+ Partials      1665     1661       -4
Files with missing lines Coverage Δ
internal/connor/all.go 83.87% <100.00%> (ø)
internal/connor/any.go 90.32% <100.00%> (ø)
internal/connor/connor.go 100.00% <100.00%> (ø)
internal/connor/eq.go 92.31% <100.00%> (ø)
internal/connor/ne.go 72.73% <100.00%> (+15.58%) ⬆️
internal/connor/none.go 83.87% <100.00%> (ø)
internal/connor/not.go 100.00% <100.00%> (ø)
internal/db/collection_get.go 79.66% <100.00%> (-4.82%) ⬇️
internal/db/collection_index.go 87.53% <100.00%> (+0.03%) ⬆️
internal/db/fetcher/fetcher.go 100.00% <ø> (ø)
... and 17 more

... and 19 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b8971...91ac5a9. Read the comment docs.

View more details on Codecov