fix: Skip new test packages in change detector #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
force-pushed
the
1494-change-detector-new-dir
branch
from
faf3c8e to
ced313e
Compare
AndrewSisley
force-pushed
the
1494-change-detector-new-dir
branch
from
ced313e to
2cc1a26
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1495 +/- ##
===========================================
- Coverage 72.21% 72.21% -0.01%
===========================================
Files 185 185
Lines 18239 18239
===========================================
- Hits 13172 13171 -1
Misses 4029 4029
- Partials 1038 1039 +1 |
shahzadlone
approved these changes
May 11, 2023
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1494 ## Description Skips new test packages in change detector instead of panicing when trying to run the setup tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1494
Description
Skips new test packages in change detector instead of panicing when trying to run the setup tests.
Tested locally,
PR includes TEMP test commit that will be removed once it has allowed testing via the CI (PR will leave draft state at that point)and with temp CI test to trigger bug.Tasks