Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: Bump github.com/ipfs/go-cid from 0.3.2 to 0.4.0 #1200

Merged
merged 4 commits into from
Mar 20, 2023
Merged

bot: Bump github.com/ipfs/go-cid from 0.3.2 to 0.4.0 #1200

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cdde02
bot: Bump github.com/ipfs/go-cid from 0.3.2 to 0.4.0
dependabot[bot] Mar 20, 2023
078ba56
fix: handle the changes in errors
orpheuslummis Mar 20, 2023
56b75da
simplify error message
orpheuslummis Mar 20, 2023
e54eb59
oops 1 line was missing in previous commit
orpheuslummis Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion planner/select.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ func (n *selectNode) initSource() ([]aggregateNode, error) {
c, err := cid.Decode(n.parsed.Cid.Value())
if err != nil {
return nil, errors.Wrap(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for removing this :)

"failed to propagate VersionFetcher span, invalid CID",
"failed to propagate VersionFetcher span",
err,
)
}
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/query/simple/with_cid_dockey_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func TestQuerySimpleWithInvalidCidAndInvalidDocKey(t *testing.T) {
}`,
},
},
ExpectedError: "invalid CID",
ExpectedError: "failed to propagate VersionFetcher span: invalid cid: selected encoding not supported",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about whether we should change the expected error message or have the request error differently.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first part of that error feels unnecessary to return to the user. Do you mind checking if you can easily remove it from the returned error?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified it, IMO it was too specific before. That said, the CID could be validated before that specific step. That would be for a different PR.

}

executeTestCase(t, test)
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/query/simple/with_cid_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func TestQuerySimpleWithInvalidCid(t *testing.T) {
}`,
},
},
ExpectedError: "failed to propagate VersionFetcher span, invalid CID: selected encoding not supported",
ExpectedError: "failed to propagate VersionFetcher span: invalid cid: selected encoding not supported",
}

executeTestCase(t, test)
Expand Down