Skip to content

Commit

Permalink
handle extra WIPs
Browse files Browse the repository at this point in the history
  • Loading branch information
orpheuslummis committed Mar 30, 2023
1 parent 5adb176 commit 349da50
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 12 deletions.
6 changes: 5 additions & 1 deletion tests/integration/cli/client_ping_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
package clitest

import (
"fmt"
"strings"
"testing"

Expand Down Expand Up @@ -54,6 +55,9 @@ func TestPingCommandToInvalidHost(t *testing.T) {

func TestPingCommandNoHost(t *testing.T) {
conf := NewDefraNodeDefaultConfig(t)
_, stderr := runDefraCommand(t, conf, []string{"client", "ping", "--url", "localhost:56788"}) //WIP
p, err := findFreePortInRange(49152, 65535)
assert.NoError(t, err)
addr := fmt.Sprintf("localhost:%d", p)
_, stderr := runDefraCommand(t, conf, []string{"client", "ping", "--url", addr})
assertContainsSubstring(t, stderr, "failed to send ping")
}
9 changes: 0 additions & 9 deletions tests/integration/cli/serverdump_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,3 @@ func TestServerDumpInvalidStoreErrs(t *testing.T) {
// assertContainsSubstring(t, stderr, "invalid datastore type")
assertContainsSubstring(t, stderr, "server-side dump is only supported for the Badger datastore")
}

func TestServerDump(t *testing.T) {
conf := NewDefraNodeDefaultConfig(t)
stopDefra := runDefraNode(t, conf)
_ = stopDefra()

_, _ = runDefraCommand(t, conf, []string{"server-dump"})
// WIP unsure why there is no output
}
2 changes: 0 additions & 2 deletions tests/integration/cli/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ func runDefraCommand(t *testing.T, conf DefraNodeConfig, args []string) (stdout,
defraCmd.RootCmd.SetArgs(args)
_ = defraCmd.Execute(ctx)
})
t.Log("⭐️ stdout", stdout) //WIP
t.Log("⭐️ stderr", stderr) //WIP
return stdout, stderr
}

Expand Down

0 comments on commit 349da50

Please sign in to comment.