Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would close #200, except that it turns out that this opens a can of worms and I'm thinking it isn't worth the trouble.
I went into this trying to develop a re-usable structure that could be applied to
stars
as well and would allow unpickling to just work. But some problems:meta
is lost. It would be feasible to fix ACAImage (requiring a new release of Ska3) or monkey patch the class. Ugh.aca
,aca.acqs
,aca.guides
, andaca.fids
would all find themselves seeing that tuple and running the function to individually get adark
value. Not so nice.Then I realized that to first order what is being pickled here in the production case isn't really getting us that much closer to the actual dark map used in selection. The kwargs are guaranteed to be the same, and there is still the need for post-processing to add the bad pixels.
So leaving this open for the moment for pondering, but I don't recommend this for 4.3.1. It still needs testing which isn't so trivial.