Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability for computed kadi states and use for attitude and sun-related states #350

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

taldcroft
Copy link
Member

Description

The prior implementation of a number of computed quantities was too tightly coupled to the ManeuverTransition and it was generally brittle and not easy to expand.

This PR recognizes that some state values like ra, dec, roll can be computed from other states (q1..4).

The implementation of this is straightforward, with the exception of dealing with the transition every 10ks in NPM to inject a state boundary and force updates to all the sun-angle values.

TODO: There is some intricacy in the code here that still needs better comments and possible cleaning.

This update changes the way that maneuver states are computed. Previously the attitude quaternion corresponded to the start of each state. This is not ideal and there was a comment suggesting that it be changed. Now the quaternion corresponds to the attitude at the midpoint of the state.

Previously there was some hackery to get the pitch, off_nom_roll to match more closely the midpoint value by averaging the start/stop values. Now the values correspond to correct mid-point values for all state bins. This is possible because the values are all computed post-facto when the state start/stop times are known.

Interface impacts

Attitude and sun-related state values will change slightly and for the better.

Testing

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant