-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing] Add debian to standard testing #3907
Conversation
135d4f2
to
e5bcdba
Compare
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
e5bcdba
to
e2be420
Compare
I'm trying to figure out what is wrong here. Tried to bring up the shell on Cirrus, and run the same command as the config, and all works. Maybe I am missing something, and I can't see it clearly and stared at it for a bit. A second head might see the issue if anyone wants to look at the PR |
a3a1063
to
f1df9d8
Compare
* Add new debian_only to replace current ubuntu_only. * ubuntu_only now only tests true for only Ubuntu distros. * Add extra packages to install for Debian ditsros, as these are not installed by default. * python3-yaml is not in the default image, and required for sunbeam plugin and saltstack collect plugins. Signed-off-by: Arif Ali <[email protected]>
f1df9d8
to
5e2304b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and the CI is passing. Was there something about this we wanted or needed to hold back on merge for 4.9, or are we good to bring it in?
no, not really, I was waiting for it to be reviewed by the team |
As per discussions in the maintainer call, wanted to start testing more on Debian, and this is a first start on testing debian regularly
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines