-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleaner] Stop obfuscation of gz files when using --keep-binary-files #3885
base: main
Are you sure you want to change the base?
Conversation
This commit tries to honour option --keep-binary-files when using cleaner by making sure that these files are skipped so the cleaner doesn't attempt to apply substitutions directly on them. Related: sosreport#3884 Signed-off-by: Jose Castillo <[email protected]>
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be using file_is_binary()
, as we're explicitly saying keep binary files.
OK, I'll change this and push again |
Hi @jcastill - Any idea when this will be merged and available in which build ? |
@suhastawade I'm working on the changes requested and I hope to have a fix based on them within the next week. |
@jcastill - I'm following up on the progress of this ticket. Do you need any further input from my side for additional analysis, or are we all set to proceed with merging these changes? |
@jcastill - Any updates on this ? |
I notice that this has not been merged yet. I would appreciate any updates on this. |
This commit tries to honour option --keep-binary-files when using cleaner
by making sure that these files are skipped so the cleaner
doesn't attempt to apply substitutions directly on them.
Related: #3884
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines