Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH/PUT Append to create a new resource #56

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

PATCH/PUT Append to create a new resource #56

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a567231
PATCH Append on new file
bourgeoa Nov 30, 2023
ca44c67
update tests for PUT with Append
bourgeoa Dec 19, 2023
8dcf691
update testing
bourgeoa Dec 19, 2023
59278f4
wrong test
bourgeoa Dec 31, 2023
e63fc5c
precondition if-none-match 412
bourgeoa Jan 28, 2024
312494c
fails on dot file .dummy
bourgeoa Feb 24, 2024
9d3723a
Allow server to send 201 on PATCH create
CxRes Aug 28, 2024
a18d54f
Merge pull request #57 from CxRes/CxRes-fix-patch-code
bourgeoa Aug 30, 2024
80e26f6
200 and 201 are allowed
bourgeoa Nov 23, 2024
1d50174
Merge branch 'patchAppendNewDocument' of https://github.com/solid-con…
bourgeoa Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/surface/create.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ describe('Create', () => {
testAllowed('Write', 'Write');
testAllowed('Append', 'Write');

it(`is disallowed without Write on c/r`, async () => {
it(`is allowed with Append on c/r`, async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

Copy link
Contributor

@edwardsph edwardsph Dec 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name to the test artifact below should be changed to match the test purpose to avoid future confusion:

const testing = `disallowed-default`;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I commit my changes to testing

const testing = `test-disallowed-default`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand Down Expand Up @@ -350,7 +350,7 @@ describe('Create', () => {
"<#patch> a solid:InsertDeletePatch;\n" +
" solid:inserts { <#hello> <#linked> <#world> .}.\n",
});
expect(result.status).toEqual(403);
expect(result.status).toEqual(200);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other OK responses should be allowed too.

});

it(`is disallowed without Write or Append on c/`, async () => {
Expand Down Expand Up @@ -554,7 +554,7 @@ describe('Create', () => {
testAllowed('Write', 'Write');
testAllowed('Append', 'Write');

it(`is disallowed without Write on c/r`, async () => {
it(`is allowed with Append on c/r`, async () => {
const testing = `disallowed-default`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand Down Expand Up @@ -589,10 +589,10 @@ describe('Create', () => {
"<#patch> a solid:InsertDeletePatch;\n" +
" solid:inserts { <#hello> <#linked> <#world> .}.\n",
});
expect(result.status).toEqual(403);
expect(result.status).toEqual(200);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I agree. This test is about required permissions on c/, right?

});

it(`is disallowed without Write or Append on c/`, async () => {
it(`is allowed with Append on c/`, async () => {
const testing = `disallowed-default`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand Down Expand Up @@ -627,7 +627,7 @@ describe('Create', () => {
"<#patch> a solid:InsertDeletePatch;\n" +
" solid:inserts { <#hello> <#linked> <#world> .}.\n",
});
expect(result.status).toEqual(403);
expect(result.status).toEqual(200);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I agree. This test is about required permissions on c/, right?

Copy link
Member Author

@bourgeoa bourgeoa Dec 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michielbdejong I should have added this link as a clarification on WAC Append solid/web-access-control-spec#122

});
});
});