Skip to content

Topic/metadata cvprop #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Topic/metadata cvprop #5428

wants to merge 14 commits into from

Conversation

nmenda
Copy link
Member

@nmenda nmenda commented Apr 11, 2025

Description

closes #5359

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@nmenda nmenda requested review from chris263 and lukasmueller April 11, 2025 01:49
chris263
chris263 approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@chris263 chris263 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nmenda nmenda marked this pull request as ready for review April 14, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris263 chris263 chris263 approved these changes

@lukasmueller lukasmueller Awaiting requested review from lukasmueller

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Both Traits and Variables Populate Under Compose New Trait for Both InventoryBases
2 participants
@nmenda @chris263