Skip to content

Make image analysis services parametrizable #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Make image analysis services parametrizable #5427

merged 1 commit into from
Apr 15, 2025

Conversation

lukasmueller
Copy link
Member

@lukasmueller lukasmueller commented Apr 10, 2025 •
edited
Loading

Description

Currently the image analysis options are hardcoded in the mason file and in the ImageAnalysis.pm class. This pull request makes it configurable in sgn_local.conf using the image_analysis_services key with the data string in JSON format. Example is in sgn.conf.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@lukasmueller lukasmueller requested review from afpowell and bm743 April 14, 2025 15:20
bm743
bm743 approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@bm743 bm743 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

afpowell
afpowell approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@afpowell afpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasmueller lukasmueller merged commit e5f6313 into master Apr 15, 2025
4 checks passed
@lukasmueller lukasmueller deleted the topic/configurable_image_analysis branch April 15, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afpowell afpowell afpowell approved these changes

@bm743 bm743 bm743 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasmueller @afpowell @bm743