-
Notifications
You must be signed in to change notification settings - Fork 37
Add an unreplicated design with diagonal checks. #5424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The tests pass for me locally, do you know what’s going on? |
The same happened to me. Could it be the R lib update? |
I updated the R libs in the docker…. Was there an update in another repo?
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Chris Simoes ***@***.***>
Sent: Saturday, April 12, 2025 11:26:54 AM
To: solgenomics/sgn ***@***.***>
Cc: Lukas A. Mueller ***@***.***>; Review requested ***@***.***>
Subject: Re: [solgenomics/sgn] Add an unreplicated design with diagonal checks. (PR #5424)
The same happened to me. Could it be the R lib update?
—
Reply to this email directly, view it on GitHub<#5424 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAAV7F32PLCOLSIDLHPKOE32ZEWD5AVCNFSM6AAAAAB22PWZYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJYHA3TINZXGQ>.
You are receiving this because your review was requested.Message ID: ***@***.***>
[https://avatars.githubusercontent.com/u/51970212?s=20&v=4]chris263 left a comment (solgenomics/sgn#5424)<#5424 (comment)>
The same happened to me. Could it be the R lib update?
—
Reply to this email directly, view it on GitHub<#5424 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAAV7F32PLCOLSIDLHPKOE32ZEWD5AVCNFSM6AAAAAB22PWZYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJYHA3TINZXGQ>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
No another update is needed. Only R lib. |
I could reproduce the error on my local system. The error is:
Since it passes sometimes locally, I think it might be a timing issue, and you should test whether a sleep(3) statement or similar after the preceding test could help? Interestingly, it finds the input field (test 38) but it can't interact with it... so maybe it is disabled in some circumstances? |
@lukasmueller I changed the way to grab row and col number. It passed all tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Chris, thanks for the fixes, it now passes all the tests :-)
Could you also remove the lint warnings?
Otherwise looks amazing.
All cleaned!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
Description
Creates un-replicated trial design with diagonal checks. It uses R package FielDHub.
To test or run this design, you will need to synchronize your R_libs to ensure that the latest version of FielDHub is available in the environment: debian_bullseye_R4.4
Fixes #5417
Checklist
/t/data/fixture/patches/
./docs
has been updated./js
to/js/source/legacy
.