Skip to content

Add an unreplicated design with diagonal checks. #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

chris263
Copy link
Contributor

@chris263 chris263 commented Apr 10, 2025

Description

Creates un-replicated trial design with diagonal checks. It uses R package FielDHub.
To test or run this design, you will need to synchronize your R_libs to ensure that the latest version of FielDHub is available in the environment: debian_bullseye_R4.4

Fixes #5417

Screenshot from 2025-04-09 23-34-08

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@chris263 chris263 changed the title Topic/unreplicate diagonal trial Add an unreplicated design with diagonal checks. Apr 10, 2025
@lukasmueller
Copy link
Member

The tests pass for me locally, do you know what’s going on?

@chris263
Copy link
Contributor Author

The same happened to me. Could it be the R lib update?

@lukasmueller
Copy link
Member

lukasmueller commented Apr 12, 2025 via email

@chris263
Copy link
Contributor Author

No another update is needed. Only R lib.

@lukasmueller
Copy link
Member

lukasmueller commented Apr 12, 2025

I could reproduce the error on my local system. The error is:

ok 38 - find field map row number input
Error while executing command: element not interactable: 
Element <input id="fieldMap_row_number" class="form-control" name="no_of_row_in_design">
is not reachable by keyboard at /home/production/cxgn/local-lib/lib/perl5/Selenium/Remote/Driver.pm line 411.
 at /home/production/cxgn/local-lib/lib/perl5/Selenium/Remote/Driver.pm line 361.

Since it passes sometimes locally, I think it might be a timing issue, and you should test whether a sleep(3) statement or similar after the preceding test could help? Interestingly, it finds the input field (test 38) but it can't interact with it... so maybe it is disabled in some circumstances?

@chris263
Copy link
Contributor Author

@lukasmueller I changed the way to grab row and col number. It passed all tests. ☺️

Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chris, thanks for the fixes, it now passes all the tests :-)

Could you also remove the lint warnings?

Otherwise looks amazing.

@chris263
Copy link
Contributor Author

All cleaned!!

Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new experimental design: Unreplicated Diagonal Arrangement
3 participants