Skip to content

fix indentation in CXGN::Trial::FieldMap #5421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025
Merged

Conversation

lukasmueller
Copy link
Member

@lukasmueller lukasmueller commented Apr 9, 2025

Description

has indents that are too large and not standard (4 spaces)

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@lukasmueller lukasmueller requested review from bm743 and alockrow April 10, 2025 15:19
Copy link
Contributor

@bm743 bm743 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alockrow
Copy link
Contributor

When I looked at the indentations on github or in a terminal editor they looked good. However, they did not show up correctly in my IDEs. I went into github settings -> Appearance and changed "Tab size preference" to 4 (instead of the default of 8) and then github matched my local IDEs. I re-adjusted the file to appropriate indentation with this formatting and committed a change. Let me know what you think.

@lukasmueller lukasmueller merged commit 8d83f27 into master Apr 14, 2025
4 checks passed
@lukasmueller lukasmueller deleted the topic/fix_indentation branch April 14, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants